New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AST-234: Create default family #7
Conversation
src/Command/CreateFamilyCommand.php
Outdated
$this->io->writeln(sprintf('Creation of asset family "%s"...', $this->assetFamilyCode)); | ||
$this->client->getAssetFamilyApi()->upsert($this->assetFamilyCode, [ | ||
'code' => $this->assetFamilyCode, | ||
'labels' => ['en_US' => 'foo'], // Need to set at least 1 label, else the UI fail :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be an empty string instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's temporary, @tseho is fixing it.
src/Command/CreateFamilyCommand.php
Outdated
'type' => $type, | ||
'value_per_locale' => $localizable, | ||
'value_per_channel' => $scopable, | ||
'is_required_for_completeness' => $required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the preview type is "image" or set it here pretty pliz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTM after fix
No description provided.