Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8 support #62

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Add PHP 8 support #62

merged 1 commit into from
Jan 4, 2021

Conversation

damien-carcel
Copy link
Contributor

No description provided.

@damien-carcel damien-carcel changed the title Accept PHP 8 as dependency Add PHP 8 support Dec 7, 2020
jmleroux
jmleroux approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@jmleroux jmleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM with a suggestion

composer.json Outdated Show resolved Hide resolved
@damien-carcel
Copy link
Contributor Author

And saddly, I'll have to wait for PHP CS fixer to be compatible with PHP 8…

@damien-carcel damien-carcel merged commit 662d4b6 into master Jan 4, 2021
@damien-carcel damien-carcel deleted the php-8 branch January 4, 2021 12:12
@Pen-y-Fan Pen-y-Fan mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahocquard ahocquard ahocquard left review comments

@jmleroux jmleroux jmleroux approved these changes

@pierallard pierallard pierallard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damien-carcel @jmleroux @pierallard @ahocquard