Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in example in maintain_pim/purge/purge_version_entities.rst #1672

Open
daveaie opened this issue Aug 24, 2021 · 0 comments
Open

Error in example in maintain_pim/purge/purge_version_entities.rst #1672

daveaie opened this issue Aug 24, 2021 · 0 comments

Comments

@daveaie
Copy link

daveaie commented Aug 24, 2021

class defined in the example implements VersionPurgerAdvisorInterface::isPurgeable, that no more return bool. Now return PurgeableVersionList. Also the parameter was changed , PurgeableVersion to PurgeableVersionList and options is no more present.

here the interface:

/**
 * Checks if a version should be purged
 *
 * @author    Samir Boulil <samir.boulil@akeneo.com>
 * @copyright 2016 Akeneo SAS (http://www.akeneo.com)
 * @license   http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
 */
interface VersionPurgerAdvisorInterface
{
    /**
     * Checks if the advisor supports the version
     *
     * @param PurgeableVersionList $versionList
     *
     * @return bool
     */
    public function supports(PurgeableVersionList $versionList);

    /**
     * Indicates the versions that needs to be purged
     *
     * @param PurgeableVersionList $versionList
     *
     * @return PurgeableVersionList
     */
    public function isPurgeable(PurgeableVersionList $versionList): PurgeableVersionList;
}

example need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant