Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile for version 1.6.0 and a README.md for Docker usage #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

auzias
Copy link

@auzias auzias commented Mar 1, 2016

Two files added:

  • Dockerfile for the latest version (1.6.0) of the-ONE.
  • README.md to details the Docker usage.

Feel free to suggest any modification.

Signed-off-by: auzias github@auzias.net

@akeranen
Copy link
Owner

I think this is interesting functionality and worth adding the simulator. However, the Dockerfile seems to fail due to mismatch in filenames
mv: cannot stat ‘akeranen-the-one-cc4cac7’: No such file or directory
The command '/bin/sh -c curl -sL https://codeload.github.com/akeranen/the-one/legacy.tar.gz/master | tar xvz && mv akeranen-the-one-cc4cac7 /home/one/the-one_1.6.0 && cd /home/one/the-one_1.6.0 && ./compile.sh && chown -R one:one /home/one' returned a non-zero code: 1

Maël Auzias added 2 commits November 29, 2016 09:38
Merge from the base project
The commit hash was appended at the end of the dirname of the untar
document root. This created an error in during the `docker-build`
procedure each time a new commit was pushed. To solve this the Dockerfile
uses a wildcard.
@auzias
Copy link
Author

auzias commented Nov 29, 2016

Thanks for pointing out the error. The update should solve this.

I'ld like to discuss whether or not the subdir 1.6.0 is usefull or not. Keeping leave the README.md (with build and run instructions) out of this directory. While this is cleaner from a Docker POV, the README.md but a .dockerignore file can be added (though this is not that important as the README.md is "neither large or sensitive files".

@akeranen
Copy link
Owner

Thanks! Now making the docker file works. Starting it fails though:
docker: Error response from daemon: invalid header field value "oci runtime error: container_linux.go:247: starting container process caused \"exec: \\\"one.sh\\\": executable file not found in $PATH\"\n".

Maybe the bash entrypoint actually makes more sense.

On the directory/file structure; if we can avoid having multiple almost identical files (for each version), that would be good. Could we use same file for multiple versions and use just e.g. env variables?

auzias added 3 commits December 18, 2016 08:34
…PATH`

I disagree on the entrypoint being `bash`. It is most likely that someone
starting this image will be willing to run the-one and not bash.

However, if `bash` is needed though it can still be started by using
`docker run` option `--entrypoint=bash`.
The Dockerfile actually build the latest version of the-one,
not the 1.6.0. Having the version as the tag is left out to
the builder.
@auzias
Copy link
Author

auzias commented Dec 18, 2016

The last two commit should solve these issues.

You may want to check the full git commit messages ;)

@GeneralMine
Copy link

Great work, works almost out of the box with just three small isuess:

Java Image

FROM java:8 doesn't work anymore, because they changed the labels. You have to change it to either FROM java:8-jdk if you want to use the oracles jdk version or FROM openjdk:8 for the open java dev kit.

MAINTAINER is deprecated

use LABEL MAINTAINER="Mael Auzias <the-one@mael.auzias.net>" instead

Typo in working dir

Running it leads to an cant find file error, because there seems to be a typo in the workdir step.
You have to change WORKDIR /home/one/the-one_lastest to WORKDIR /home/one/the-one_latest in order to fix it.


I might open a new pr containing a working version for linux and windows with wsl2 and docker soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants