-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact-Based Routing (CBR) #45
base: master
Are you sure you want to change the base?
Conversation
Thank you Juliano.
…On Mon, Mar 13, 2017 at 12:01 AM, Juliano Fischer Naves < ***@***.***> wrote:
Very nice, congratulations!
ASAP I will read this code.
I think @akeranen <https://github.com/akeranen> and @tk721
<https://github.com/tk721> will consider adding it to the code after a
review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIXjjEfgRW2I6ONflOVU_WhUhzKyIKYEks5rlDnvgaJpZM4MMHM9>
.
--
Thanks & Regards
Sujata Pal, PhD
Assistant Professor, CSE
IIT Ropar, India
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some style issues, but otherwise OK
src/routing/CBR.java
Outdated
@Override | ||
public void update() { | ||
super.update(); | ||
//if(SimClock.getIntTime() == 43200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to clean up the code before merging. And there's actually the core.Debug.p method for debug prints.
src/routing/CBR.java
Outdated
public void update() { | ||
super.update(); | ||
//if(SimClock.getIntTime() == 43200) | ||
//System.out.println("[" + this.getHost() + "] list: " + this.nodesInf + "\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
src/routing/CBR.java
Outdated
ArrayList<Integer> items = otherRouter.nodesInf.get(msgDst.getAddress()); | ||
|
||
int encounter = items.get(0); | ||
if (encounter > maxEnc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style issue: opening curly brackets on the same line in ifs
(also below)
Hi @SujataPal, maybe you would like to comment your source code. Would be nice! |
I think renaming CBR.java to CBRRouter.java is a good idea since all routing classes are named following this rule. |
Hi Ari/Juliano, I have changed the code according to your suggestion and renamed CBR.java to CBRRouter.java as per Juliano. Thank you, |
Hi,
I would like to contribute the code for CBR.