Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read appkey at runtime #53

Closed
wants to merge 5 commits into from
Closed

read appkey at runtime #53

wants to merge 5 commits into from

Conversation

escoand
Copy link

@escoand escoand commented Jan 30, 2013

add functionality to read appkey at runtime
so it could be published as binary and there is no need to compile it

@akezeke
Copy link
Owner

akezeke commented Jan 31, 2013

Hi,

Just to let you know... the reason why you cant share a precompiled XBMC with spotyxbmc is not due to the api-key. The key is no problem to share in a precompiled application (read spotify api license).

The problem is that you violates XBMC license. It says that you cant have a precompiled version of XBMC that contains closed source parts (like spotify API).

The solution for this is rather to have the spotify api loaded in realtime and not just the key. It is possible of course but I dont have the time to do it and I have no problems compiling myself.

regards
David

@escoand
Copy link
Author

escoand commented Jan 31, 2013

What has to be extracted and separated? Can you give a list (of files/classes/functions)?
The library itself is separated. In my opinion the API is only the part to interact with that library - or am I wrong?
Do we need a separated library to load the spotify library?

@akezeke
Copy link
Owner

akezeke commented Feb 1, 2013

What has to be done is that the library (libspotify.dll in windows) cant be static linked. It has to be dynamically loaded when xbmc is running.

@bdunogier
Copy link

@akezeke, could you enlighten us on the status of binary addons in XBMC ? Is it somehow part of the roadmap ? And if yes, is what's planned sufficient for you to distribute the spotify part as a distinct addon ?

I don't really see much going on in this regards, but the XBMC community can be hard to follow...

@escoand
Copy link
Author

escoand commented Feb 5, 2013

take a look at the other pull request, it is adding dynamic library linking

@escoand escoand closed this Feb 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants