Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhan settings do not show Rule Machine 5.0 rules #2

Closed
akhandok opened this issue Nov 30, 2021 · 1 comment
Closed

Adhan settings do not show Rule Machine 5.0 rules #2

akhandok opened this issue Nov 30, 2021 · 1 comment
Assignees
@akhandok

Comments

@akhandok
Copy link
Owner

On the Adhan Settings page for each Adhan, the dropdown for selecting which Rule Machine rules to run only shows Rule Machine 4.1 and below rules; Rule Machine 5.0 rules are not shown.
@akhandok
Copy link
Owner Author

This is because the code does not specify 5.0:

adhanPlayer/app.groovy

Line 77 in 3617990

input getAdhanRMRulesVariableName(adhan), "enum", title: "Select which rule(s) to run at Adhan time", options: (RMUtils.getRuleList() ?: []), multiple: true

See comment here: https://community.hubitat.com/t/rule-machine-api/7104/73

@akhandok akhandok self-assigned this Nov 30, 2021
akhandok added a commit that referenced this issue Nov 30, 2021
@akhandok
#2: Rule Machine 5.0 support
5c4fb35
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhandok akhandok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akhandok