Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of latest parameter values when no data is available #157

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

akhenry
Copy link
Owner

@akhenry akhenry commented Jul 1, 2022

Closes nasa/openmct#5385

Describe your changes:

This bug was due to a recent unrelated change in our parameter subscriptions which means that Yamcs now sends us back the latest value for a parameter immediately. If Yamcs has nothing in its latest data table (because no parameter value has been received since the last restart) then Yamcs will return an slightly different response, which was being incorrectly interpreted as a telemetry value.

Note that fixing this issue unearthed another problem, which I have also fixed in a separate PR.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@akhenry akhenry requested a review from shefalijoshi July 1, 2022 21:40
Copy link
Collaborator

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shefalijoshi shefalijoshi merged commit 6fde393 into release/2.0.5 Jul 1, 2022
@shefalijoshi shefalijoshi deleted the fix-invalid-date branch July 1, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants