Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use target-based cmake settings #664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use target-based cmake settings #664

wants to merge 1 commit into from

Conversation

Andrew-Au
Copy link

  • Update minimum required to CMake version 3.5 (versions older than 3.5 are deprecated as of 3.27)
  • update add_definitions to target_compile_definitions
  • use target_include_directories for public library includes

@Andrew-Au
Use target-based cmake settings
97ca587 
- Update minimum required to CMake version 3.5 (versions older than 3.5 are
deprecated as of 3.27)
- update add_definitions to target_compile_definitions
- use target_include_directories for public library includes
@Andrew-Au
Copy link
Author

resolves #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Andrew-Au