Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved login condition out of Trait #46

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Moved login condition out of Trait #46

wants to merge 9 commits into from

Conversation

SwarajKR
Copy link
Collaborator

@SwarajKR SwarajKR commented Oct 6, 2017

No description provided.

@SwarajKR SwarajKR closed this Oct 13, 2017
Copy link
Owner

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After moving the login condition, the login is working as expected.

@akhilerm akhilerm reopened this Oct 13, 2017
Copy link
Owner

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working as expected. can still access another user's file

@akhilerm
Copy link
Owner

In fbe4169 user can't cd into another user's directory. Enforced by calculating levels of directory. But if the user is in a question directory cd ../question_name will give output as No such directory

@SwarajKR
Copy link
Collaborator Author

in cd path should be calculated as following.
$user_dir should be pwd (execute shell command/use previous pwd)
concat it with $args[0]
session - pwd should be new dir - user's home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants