Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window sets as a desktop widget at the bottom of all windows, once it loses focus. #11

Merged

Conversation

anandphulwani
Copy link
Contributor

Resolved the topOrNot problem, do check and reply.
You said HELP WANTED, so help comes at your doorstep. :)

@akhilesh-balaji
Copy link
Owner

Hi, thanks for your contribution. I tested this out, but the notes window does not seem to reappear when all windows lose focus, for instance, when using Win+D. In the current implementation, it regains topmost window status when such an interaction takes place.

However, the current implementation is flawed in that the notes window regains topmost status when an untitled window (e.g., a Chromium extension popup) is focused.

Let me know what your thoughts are; thanks for your interest.

@anandphulwani
Copy link
Contributor Author

Understood, if you want me to rectify this, i can, but i want to leave this out for you, in order to understand the changes better, i am sure you will figure it out.

Earlier, i was facing a lot of issues with flickering, i wasn't able to work at all, were you also facing this issue at your end?

@anandphulwani
Copy link
Contributor Author

I apologize, i really misread your comment, probably because i was tired from last night, i have made the changes for you to check, it works on "Win+D" now, i have sent new updates to the same branch.

@akhilesh-balaji
Copy link
Owner

Hi, thanks very much for the contribution, and for the readable code—I wrote the bulk of this code a few years back; it is thus not very organized and uses some questionable conventions.

The implementation works very well—there were some flickering issues (as you mentioned) with the earlier implementation, but this appears to have fixed that.

I would now only ask you to make minor reformatting changes by a) changing function and variable names to use camel case (Python code typically uses underscores, but this code questionably deviates from that) and b) formatting the code using PEP8 guidelines, i.e., just run the file through autopep8 once and re-check for breaking changes.

I will merge the PR after these minor edits.

Thank you once more for your work!

@akhilesh-balaji akhilesh-balaji merged commit f69a863 into akhilesh-balaji:master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants