Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null name, no capitalize & introduce eslint fix command #77

Merged
merged 4 commits into from
May 3, 2024
Merged

Fix null name, no capitalize & introduce eslint fix command #77

merged 4 commits into from
May 3, 2024

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented May 2, 2024 •
edited

  • Fallback to username in case the name is empty/null
  • I actually removed the capitalized usage, since my name is already CORRECTly capitalized in GitHub itself, and your method is actually making it worse not better. For example my name is: "Melroy van den Berg". And NOT.. "Melroy Van Den Berg". So no need to manually capitalize it.
  • Introduce a simple eslint auto-fix npm command (npm run fix)
  • Also ran npm run build already for you 👍🏽

Fixes: #60

@melroy89 melroy89 mentioned this pull request May 2, 2024
Closed
@melroy89 melroy89 changed the title Fix null name & introduce eslint fix command Fix null name, no capitalize & introduce eslint fix command May 2, 2024
@reinder
Copy link

reinder commented May 2, 2024

Awesome, hope it gets merged soon :)

@akhilmhdh
Copy link
Owner

Ohh wow @melroy89

I am a bit tired tonight and yes i was pretty busy with my other works I never had time to focus on this task.

Appreciate your efforts for fixing it. I'll review and hopefully release this tomorrow for sure.

@melroy89
Copy link
Contributor Author

melroy89 commented May 2, 2024

Appreciate your efforts for fixing it. I'll review and hopefully release this tomorrow for sure.

Understood. Thanks in advance. Sleep well I would say :).

@akhilmhdh akhilmhdh merged commit c78bc93 into akhilmhdh:master May 3, 2024
@akhilmhdh
Copy link
Owner

akhilmhdh commented May 3, 2024 •
edited

Hey @melroy89 it has been released under v2.3.9. Again thanking you for taking your time on this one.

CC: @reinder

@reinder
Copy link

reinder commented May 3, 2024

Awesome 😎 thx!

reinder added a commit to traintastic/traintastic that referenced this pull request May 3, 2024
@reinder
Updated contributors-readme-action to v2.3.9
423cb9b 
see akhilmhdh/contributors-readme-action#77
@melroy89 melroy89 mentioned this pull request May 3, 2024
Merged
@melroy89 melroy89 deleted the fix_null_name branch May 3, 2024 16:44
@melroy89
Copy link
Contributor Author

melroy89 commented May 3, 2024

Hey @melroy89 it has been released under v2.3.9. Again thanking you for taking your time on this one.

CC: @reinder

You're welcome all! Have a nice day.

reinder added a commit to traintastic/traintastic that referenced this pull request May 11, 2024
@reinder
Updated contributors-readme-action to v2.3.9
ca815ca 
see akhilmhdh/contributors-readme-action#77
@KazooTTT KazooTTT mentioned this pull request May 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilmhdh akhilmhdh akhilmhdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing contributor & contributor name null
3 participants
@melroy89 @reinder @akhilmhdh