Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160341907 Fix Date Utility #25

Merged
merged 1 commit into from
Sep 7, 2018
Merged

#160341907 Fix Date Utility #25

merged 1 commit into from
Sep 7, 2018

Conversation

akhilome
Copy link
Owner

@akhilome akhilome commented Sep 7, 2018

What does this PR do?

Fixes order date error when making new orders

Description of Task to be completed?

  • break the padding function out of the date function
  • write tests and make them pass for padding function
  • rewrite tests for date function and make them pass

How should this be manually tested?

Clone the repo. After cloning, cd into it and run npm test from the command line.

What are the relevant pivotal tracker stories?

#160341907

- break the padding function out of the date function
- write tests and make them pass for padding function
- rewrite tests for date function and make them pass

[Finishes #160341907]
@akhilome akhilome merged commit 04d276d into develop Sep 7, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 33

  • 21 of 21 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 100.0%

Totals Coverage Status
Change from base Build 30: 0.6%
Covered Lines: 188
Relevant Lines: 188

💛 - Coveralls

@akhilome akhilome deleted the bg-fix-date-160341907 branch September 25, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants