Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161101925 Stop showing invalid email #57

Merged
merged 1 commit into from Oct 9, 2018

Conversation

akhilome
Copy link
Owner

@akhilome akhilome commented Oct 9, 2018

What does this PR do?

Fixes bug where API alerts user during login whether or not the provided email exists in the database

Description of Task to be completed?

  • make error message ambiguous upon provision of invalid email/password during login.

How should this be manually tested?

  • Clone the git repo, and setup project as per described in README
  • Start the app by running npm start from terminal
  • Fire up postman and hit the http://localhost:3000/api/v1/auth/login/ endpoint providing an invalid email address or password

What are the relevant pivotal tracker stories?

#161101925

@akhilome akhilome merged commit 90cd99f into develop Oct 9, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 97.861% when pulling 3e0e189 on bg-invalid-email-161101925 into dbdbeb3 on develop.

@akhilome akhilome deleted the bg-invalid-email-161101925 branch October 11, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants