Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163532409 Fix React missing key prop violation warning #17

Merged
merged 1 commit into from Jan 28, 2019

Conversation

akhilome
Copy link
Owner

@akhilome akhilome commented Jan 28, 2019

What does this PR do?

fix react key prop violation warnings

Description of Task to be completed?

  • add unique key props to every order card

What are the relevant pivotal tracker stories?

#163532409

Screenshots (if appropriate)

image

Closes #16

@akhilome akhilome merged commit d45b4ea into develop Jan 28, 2019
@akhilome akhilome deleted the bg-key-prop-163532409 branch January 28, 2019 20:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 47

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 98.795%

Totals Coverage Status
Change from base Build 44: 0.005%
Covered Lines: 246
Relevant Lines: 249

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add key prop to order cards on order history pages
2 participants