Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163571991 Mobile Navigation Not Showing #19

Merged
merged 1 commit into from Jan 29, 2019

Conversation

akhilome
Copy link
Owner

@akhilome akhilome commented Jan 29, 2019

What does this PR do?

fix navigation not showing up on small viewports

Description of Task to be completed?

  • add necessary script to html file to toggle mobile nav at certain view breakpoints

How should this be manually tested?

  • clone the repo and cd into it
  • run npm i to install project deps
  • run npm run dev to start up the application
  • open up the app in a small viewport

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#163571991

Screenshots (if appropriate)

image

image

@akhilome akhilome merged commit 0658982 into develop Jan 29, 2019
@akhilome akhilome deleted the bg-mobile-nav-163571991 branch January 29, 2019 21:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 57

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.864%

Totals Coverage Status
Change from base Build 54: 0.0%
Covered Lines: 261
Relevant Lines: 264

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants