New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#163724488 Mobile Navigation not showing up consistently. #20

Merged

akhilome merged 1 commit into develop from bg-mobile-nav-163724488

Feb 5, 2019

Owner

akhilome commented Feb 5, 2019

What does this PR do?

fixes mobile not displaying properly

Description of Task to be completed?

switch over to using reactjs to implement mobile nav toggling

How should this be manually tested?

clone the repo and cd into it
run npm i to install project deps
run npm run dev to start up the application
open up the app in a small viewport

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

N/A


          bg(mobile-nav): fix mobile not displaying properly

b1e4c85

- switch over to using reactjs to implement mobile nav toggling

[Fixes #163724488]

coveralls commented Feb 5, 2019

Pull Request Test Coverage Report for Build 61

3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 98.491%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/Nav.jsx	3	4	75.0%

Totals
Change from base Build 58:	-0.4%
Covered Lines:	261
Relevant Lines:	265

💛 - Coveralls

akhilome merged commit 511e47e into develop

akhilome deleted the bg-mobile-nav-163724488 branch

February 7, 2019 21:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment