Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native implementation can be made faster. #8

Closed
gnudles opened this issue Nov 8, 2021 · 0 comments · Fixed by #10
Closed

native implementation can be made faster. #8

gnudles opened this issue Nov 8, 2021 · 0 comments · Fixed by #10

Comments

@gnudles
Copy link

gnudles commented Nov 8, 2021

you use the bitcount32 for native implementation. you do twice as work as needed. you shoud tweak your code a bit to support 64 bit integers and use it in native implementation.
akhomchenko added a commit that referenced this issue Nov 16, 2021
@akhomchenko
improve native bitcount implementation by switching to 64 bit version
c7d3b78 
Change replaces 2 32 bit bitcounts + shift to a single 64 bit bitcount.

Change also switches mechanism that provides implementation. Code no longer
relies on dart2js implementation but uses standard conditional import with
dart js library.

Closes #8. Thanks to @gnudles for reporting.
@akhomchenko akhomchenko mentioned this issue Nov 16, 2021
Merged
akhomchenko added a commit that referenced this issue Nov 16, 2021
@akhomchenko
improve native bitcount implementation by switching to 64 bit version
8d7d838 
Change replaces 2 32 bit bitcounts + shift to a single 64 bit bitcount.

Change also switches mechanism that provides implementation. Code no longer
relies on dart2js implementation but uses standard conditional import with
dart js library.

Closes #8. Thanks to @gnudles for reporting.
@akhomchenko akhomchenko mentioned this issue Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More effective bitcount on native akhomchenko/bitcount
1 participant
@gnudles