Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More jasmine2 updates #2

Merged
merged 10 commits into from Jun 2, 2015

Conversation

tomv564
Copy link

@tomv564 tomv564 commented May 25, 2015

Because the runners/reporters share some code now, files have been moved.
Add this to package.json jest config, existing tests should all pass without modification:

"testRunner": "./jasmineTestRunner/jasmine2TestRunner"

The following changes are ready:

  • Implement the last few updates to the jasmine 1.3 runner and reporter in our jasmine 2 versions
  • ancestorTitles reported correctly
  • Use jasmineDone event to resolve testResults from reporter
  • Fix matchers and add tests
  • Make existing tests compatible with jasmine 2 and jasmine 1.3
  • Extracted common code in both runners and reporters

The following issues remain:

  • Huge stack traces reported by the jasmine2Runner on matcher failure and especially exceptions.
  • IsNot flag on result is missing in jasmine 2, did not test if jasmine2Reporter's output is correct.
  • Documentation

akhomchenko added a commit that referenced this pull request Jun 2, 2015
@akhomchenko akhomchenko merged commit ebd2500 into akhomchenko:update_jasmine Jun 2, 2015
@tomv564 tomv564 deleted the update_jasmine branch June 2, 2015 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants