Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment that class is not copyable should be = delete #36

Closed
donmac703 opened this issue Apr 30, 2020 · 1 comment
Closed

Comment that class is not copyable should be = delete #36

donmac703 opened this issue Apr 30, 2020 · 1 comment

Comments

@donmac703
Copy link

lalr1.cc has comments of the form:
/// This class is not copyable.
For modern versions of C++ this is enforced using = delete instead of hiding it as a private member.
akimd added a commit that referenced this issue May 1, 2020
@akimd
c++: use modern idioms to make classes non-copyable
30357ae 
Reported by Don Macpherson.
https://lists.gnu.org/r/bug-bison/2019-05/msg00015.html
#36

* data/skeletons/lalr1.cc, data/skeletons/stack.hh,
* data/skeletons/variant.hh: Delete the copy-ctor and the copy operator.
@akimd
Copy link
Owner

akimd commented May 1, 2020

Fix in master. https://lists.gnu.org/r/bug-bison/2020-05/msg00000.html

Thanks for the reminder!

@akimd akimd closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akimd @donmac703