C++ support for custom error messages #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akimd
requested changes
Feb 27, 2020
* data/skeletons/lalr1.cc: here * etc/bench.pl.in: here * src/location.c: here * tests/calc.at: and here
Prefer b4_parse_error_case over the adhoc solution `m4_case + b4_percent_define_get`. Same for b4_parse_error_bmatch. * data/skeletons/glr.c: here * data/skeletons/yacc.c: here
* data/skeletons/lalr1.cc: added support here * tests/calc.at: added a test case
* data/skeletons/lalr1.cc: here
* data/skeletons/lalr1.cc: added support here * tests/calc.at: added test cases * tests/local.at: added yyreport_syntax_error implementation for C++ test cases
vogelsgesang
force-pushed
the
cpp_custom_error
branch
from
a85bd8c
to
4d5db32
Compare
|
Your comments should be addressed now with my updated commits |
akimd
reviewed
Feb 27, 2020
| @@ -2267,7 +2267,7 @@ yyreportSyntaxError (yyGLRStack* yystackp]b4_user_formals[) | |||
| while ((*yyp = *yyformat)) | |||
| { | |||
| if (*yyp == '%' && yyformat[1] == 's' && yyi < yycount) | |||
| {]m4_case(b4_percent_define_get([[parse.error]]), [verbose], [[ | |||
| {]b4_parse_error_case( [verbose], [[ | |||
akimd
reviewed
Feb 27, 2020
| , yyla (yyla) | ||
| {} | ||
| ]b4_locations_if([[ | ||
| const location_type& get_location () const { return yyla.location; } |
There was a problem hiding this comment.
I'd prefer location_get (like type_get), or just location.
You did thanks! Sorry for the minor issues I missed the first time. I will install your changes this evening. Cheers! |
akimd
approved these changes
Feb 27, 2020
|
I'll fix these final minor issues, and push that onto savannah. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mailing list for discussion
The first 8 commits by @akimd in this review are coming from my rebase on the official upstream repo (https://git.savannah.gnu.org/git/bison.git). I guess the master here on github is not up-to-date with the upstream repo.
In any way: the newly added commits are only the last 4 commits