complete: fix empty completions with "FIGNORE"

akinomyoga · Dec 17, 2021 · 144ea5d · 144ea5d
1 parent acc9661
commit 144ea5d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/docs/ChangeLog.md b/docs/ChangeLog.md
@@ -202,6 +202,8 @@
 - util (`ble/util/readfile`): fix a bug of always exiting with 1 in `bash <= 3.2` (reported by laoshaw) `#D1678` 61705bf
 - trace: fix wrong positioning of the ellipses on overflow `#D1684` b90ac78
 - complete: do not generate keywords for quoted command names `#D1691` 60d244f
+- complete: fix empty completions with `FIGNORE` (reported by seanfarley) `#D1711` 0000000
+
 
 ## Documentation
 

diff --git a/lib/core-complete.sh b/lib/core-complete.sh
@@ -4660,6 +4660,7 @@ function ble/complete/.fignore/filter {
   for pat in "${_fignore[@]}"; do
     [[ $1 == *"$pat" ]] && return 1
   done
+  return 0
 }
 
 ## @fn ble/complete/candidates/.pick-nearest-sources

diff --git a/note.txt b/note.txt
@@ -5666,6 +5666,14 @@ bash_tips
     Done (実装ログ)
 -------------------------------------------------------------------------------
 
+2021-12-18
+
+  * complete: FIGNORE で全てが棄却されるバグ (reported by seanfarley) [#D1711]
+    https://github.com/akinomyoga/ble.sh/issues/162
+
+    これは極めて単純なバグだった。そもそも実は FIGNORE は今まで全く動いていなかっ
+    たと思われる。
+
 2021-12-16
 
   * menu-complete で 30s かかるという話 (1/2) construct-page のバグ (reported by banoris) [#D1710]