[WIP] Keep current buffer position consistent #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigating backwards and forwards don't move the current buffer along rather than shifting the other buffers around it which is disconcerting
akinsho
force-pushed
the
feature/consistent-buffer-position
branch
from
4909030
to
00240d7
Compare
akinsho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating backwards and forwards move the current buffer
along rather than shifting the other buffers around it which is
disconcerting. This PR shifts things so we move all the way across a "page" rather than "flowing" the other buffers around the current one.
New:
Old:
NOTE: Currently it shifts the page when navigating past the penultimate buffer on the left or right which is a little bit intuitive but this is generally an improvement.