fix(hover): check showtabline not laststatus #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
akinsho
requested changes
Nov 16, 2022
There was a problem hiding this comment.
@vimpostor would be great if you could tweak this PR to add a check for whether the tabline is showing or not, which was my original intention there.
Hover events work just fine if laststatus=0 and this check breaks in combination with other plugins, for example see: vimpostor/vim-tpipeline#39 Instead we can check for `showtabline`, because we probably don't want to process hover events if the tabline is disabled. refs: akinsho#539
vimpostor
force-pushed
the
relaxhover
branch
from
2d59513
to
bf7f868
Compare
akinsho
changed the title
|
Thanks for the contribution 👍🏿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not really a point in gatekeeping this feature from
laststatus=0.The hover feature works completely fine with
laststatus=0and this creates only problems with other plugins, see: vimpostor/vim-tpipeline#39