feat: allow moving buffers to arbitrary positions #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinsho
requested changes
Feb 15, 2023
There was a problem hiding this comment.
@MisterFISHUP thanks for the PR. I don't mind the idea of adapting the move function to allow specifying a position to move to, but the current solution is not DRY at all and I think it can be reworked. The move function should be adapted to take an index and when used in the existing mappings the arguments should be calculated.
akinsho
reviewed
Feb 17, 2023
akinsho
changed the title
|
Thanks for all your work on this @MisterFISHUP much appreciated 👍🏿 |
|
Thank you for merging this PR, and for all the useful guides you have provided! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
move_tofunction andBufferLineMoveTo{First|Last}commands so one can easily move the current buffer to then-th position in the bufferline.It's a bit like
:tabmovebut for buffers.move_totakes an 1-based buffer index. Negative integers are allowed but 0 is ignored.P.S. This is an awesome project! Thank you to all the maintainers for putting in so much time and effort to make this possible. I'm really enjoying using it and I'm so grateful for all the work that went into it. Keep up the great work!"