Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(group): check that group exists before operating on it #681

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

otavioschwanck
Copy link
Contributor

@otavioschwanck otavioschwanck commented Feb 16, 2023

Fixes #678

Copy link
Owner

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one minor nit

@@ -301,6 +301,11 @@ function M.command(group_name, callback)
function(list) return list.name == group_name end,
state.components_by_group
)

if not(group) then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parentheses aren't required around conditional clauses in lua

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akinsho fixed!

@akinsho akinsho changed the base branch from main to dev February 16, 2023 16:29
@akinsho akinsho changed the title fix error when empty list of buffers fix(group): check that group exists before operating on it Feb 16, 2023
@akinsho akinsho merged commit f9239e4 into akinsho:dev Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: error when there are no tabs to close with GroupClose
2 participants