Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(groups): close and unpin #698

Merged
merged 1 commit into from
Mar 30, 2023
Merged

feat(groups): close and unpin #698

merged 1 commit into from
Mar 30, 2023

Conversation

otavioschwanck
Copy link
Contributor

Fixes #697

PS:
i didn't create a public commands.

@otavioschwanck otavioschwanck changed the base branch from main to dev February 23, 2023 02:47
@akinsho akinsho deleted the branch akinsho:dev March 2, 2023 22:26
@akinsho akinsho closed this Mar 2, 2023
@akinsho akinsho reopened this Mar 2, 2023
@akinsho akinsho deleted the branch akinsho:dev March 30, 2023 16:39
@akinsho akinsho closed this Mar 30, 2023
@akinsho akinsho reopened this Mar 30, 2023
@akinsho
Copy link
Owner

akinsho commented Mar 30, 2023

Really annoyingly this gets autoclosed when I merge dev into main because that branch keeps getting autoclosed. I'm kind of fine with this functionality but a bit worried about all these very special purpose functions like remove manual grouping. Not sure if having them means something needs refactoring (Just thinking out loud)

akinsho
akinsho approved these changes Mar 30, 2023
View reviewed changes
Copy link
Owner

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge this in for now and have a think over the next dev cycle

@akinsho akinsho changed the title Feature/close and unpin feat(groups): close and unpin Mar 30, 2023
@akinsho akinsho merged commit d129e86 into akinsho:dev Mar 30, 2023
@akinsho akinsho mentioned this pull request Mar 30, 2023
Closed
1 task
akinsho pushed a commit that referenced this pull request Apr 1, 2023
@otavioschwanck @akinsho
feat(groups): close and unpin (#698)
52241b5 
add a command to allow a buffer to be both closed and unpinned so that it isn't autopinned on next re-opening it
@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinsho akinsho akinsho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Closed buffer stays pinned if open again
2 participants
@otavioschwanck @akinsho