Fix `disable_test_id_escaping_and_forfeit_all_rights_to_community_sup…

…port` option when using a list of test IDs
akiomik · May 21, 2019 · a304dbb · a304dbb
1 parent 6663cb0
commit a304dbb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/AUTHORS b/AUTHORS
@@ -9,6 +9,7 @@ Abhijeet Kasurde
 Adam Johnson
 Adam Uhlir
 Ahn Ki-Wook
+Akiomi Kamakura
 Alan Velasco
 Alexander Johnson
 Alexei Kozlenok

diff --git a/changelog/5286.bugfix.rst b/changelog/5286.bugfix.rst
@@ -0,0 +1 @@
+Fix issue with ``disable_test_id_escaping_and_forfeit_all_rights_to_community_support`` option doesn't work when using a list of test IDs in parametrized tests.
diff --git a/src/_pytest/python.py b/src/_pytest/python.py
@@ -1217,7 +1217,7 @@ def _idvalset(idx, parameterset, argnames, idfn, ids, item, config):
         ]
         return "-".join(this_id)
     else:
-        return ascii_escaped(ids[idx])
+        return _ascii_escaped_by_config(ids[idx], config)
 
 
 def idmaker(argnames, parametersets, idfn=None, ids=None, config=None, item=None):