Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Add extra checks by melpazoid #24

Closed
wants to merge 6 commits into from
Closed

Add extra checks by melpazoid #24

wants to merge 6 commits into from

Conversation

akirak
Copy link
Owner

@akirak akirak commented Jul 5, 2020

This adds the following checks by melpazoid:

  • melpazoid-check-sharp-quotes
  • melpazoid-check-misc

Implementation status:

  • Add Nix API for running the check
  • Extend the CLI to support the functionality

I plan on adding the check to lint command of the CLI. It will be the default, but I will add a switch to disable the check (like --no-melpazoid).

The output will be like this:

==========================================================
melpazoid on bad-hello package
==========================================================
Running the following checks from melpazoid.el:
- melpazoid-check-sharp-quotes
- melpazoid-check-misc
----------------------------------------------------------
Running checks on tests/bad-hello.el...

bad-hello.el#L36: Top-level bind-keys can overwrite user keybindings.  Try: `(defvar my-map (let ((km (make-sparse-keymap))) (bind-keys ...) km))`
> (bind-keys ("<f12> <f11> <f10>" . #'emacs-version))

bad-hello.el#L32: Consider `unless ...` instead of `when (not ...)`
>   (when (not t)

bad-hello.el#L19: Prefer `https` over `http` (if possible)
> ;; along with this program.  If not, see <http://www.gnu.org/licenses/>.
----------------------------------------------------------
Errors found by melpazoid.

@akirak
Copy link
Owner Author

akirak commented Aug 4, 2020

Already implemented in v4.

@akirak akirak closed this Aug 4, 2020
@akirak akirak deleted the feature/core/melpazoid branch November 24, 2020 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant