New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16.6 StrictMode: findDOMNode is deprecated in StrictMode #1406
Comments
Thanks @apepper Can you raise a PR to fix this issue ? |
Sorry, but no. |
I think this PR could be safely accepted as it won't break any of the slider functionality, it's just a react maintenance issue. |
akiran
added a commit
that referenced
this issue
Jul 17, 2020
Got rid of ReactDOM.findDOMNode (#1406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thanks for your package. It's quite a help to have it.
I just checked out the latest
react
16.6.0
release. They extended APIs inStrictMode
, that are now considered deprecated.findDOMNode
is now considered deprecated. See https://reactjs.org/blog/2018/10/23/react-v-16-6.html#deprecations-in-strictmode for the full list.If you add
React.StrictMode
aroundSlick
you'll get the following console warning:See it live on https://codesandbox.io/s/8j39k1pq8. Also see https://fb.me/react-strict-mode-find-node for how to get rid of the warning.
The text was updated successfully, but these errors were encountered: