-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 Compatibility #103
IE8 Compatibility #103
Conversation
pull for update
|
||
for (var i=0; i<dotCount; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sorrycc I don't see a need for this change. Please revert changes on this particular file.
I'll look at this PR in the weekend. I am bit busy with my college work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's don't work in IE8 either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume one has included es5-shim for IE8 supporting, .map
for array should be safe. The problem is within .apply
. It should be: var dots = Array.apply(null, Array(dotCount + 1).join('0').split('')).map(...
Tested with native IE8, it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vramana To make ReactJS work with IE8, you have to include es5-shim anyway. Also I think it's not necessary to include the polyfill for addEventListener, it should be specified in README like ReactJS does in its doc.
http://facebook.github.io/react/docs/working-with-the-browser.html#browser-support-and-polyfills
I can send another PR for all these stuffs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close #102