Fixing issue with asNavFor not detecting all slide changes #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsenichev
approved these changes
Nov 20, 2018
|
Approve it! |
|
This is a major issue for me.. |
jonlow
approved these changes
Dec 4, 2018
|
Hello folks, |
mehdi-cit
added a commit
to mehdi-cit/react-slick
that referenced
this pull request
Dec 5, 2018
Fix described in "akiran#1423" works for me but has not been integrated with
piovischioh
approved these changes
Dec 11, 2018
|
Why are you not merging this? This is effecting my project and I'l likely pull this dependency if you don't fix it. |
simkesd
added a commit
to simkesd/react-slick
that referenced
this pull request
Dec 24, 2018
Got the fix from here akiran#1423
I am in the same situation. 😕 |
|
Just wanted to add support for merging this in - it fixed a big headache for me as well. |
franciscoaguirre
approved these changes
Feb 22, 2019
|
Please merge! |
Closed
the1975
approved these changes
Apr 5, 2019
mzmijana
approved these changes
Apr 8, 2019
piovischioh
approved these changes
Apr 9, 2019
|
Guys, we could use patch-package to fix it for instant. patch-package
--- a/node_modules/react-slick/lib/inner-slider.js
+++ b/node_modules/react-slick/lib/inner-slider.js
@@ -410,7 +410,7 @@
});
onLazyLoad && slidesToLoad.length > 0 && onLazyLoad(slidesToLoad);
_this.setState(state, function () {
- asNavFor && asNavFor.innerSlider.state.currentSlide !== currentSlide && asNavFor.innerSlider.slideHandler(index);
+ asNavFor && asNavFor.innerSlider.state.currentSlide !== _this.state.currentSlide && asNavFor.innerSlider.slideHandler(index);
if (!nextState) return;
_this.animationEndCallback = setTimeout(function () {
var animating = nextState.animating, |
luke-underwood
approved these changes
Apr 15, 2019
|
@akiran can you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the slider has the "asNavFor" configuration, the detection of the slide changes from one slider to the next does not always work. It might work always, or in other occassions, only on every other change.
The issue is that the second slider needs to be refreshed when the slide it points to is different to that of the parent slider, after this parent slider has updated.
This should fix #1416