Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow user to invert order of side panels. Fixes #79 #365

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

guillotjulien
Copy link
Contributor

Summary / How this PR fixes the problem?

This PR implements a new settings that allow users to change the order of the sidebars.

Screenshots

image
image

This PR fixes/implements the following bugs/features:

Copy link
Member

@Alecaddd Alecaddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions.
I listed some required changes before approving this PR.

data/schemas/com.github.akiraux.akira.gschema.xml.in Outdated Show resolved Hide resolved
Comment on lines 108 to 114
grid.attach (new SettingsLabel (_("Invert Sidebars Order:")), 0, 5, 1, 1);
symbolic_switch = new SettingsSwitch ("invert-sidebar");
grid.attach (symbolic_switch, 1, 5, 1, 1);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here but underneath the Interface header, right after the Dark Theme switch.

Since this option requires a reboot, we should specify it in a helper text underneath.
Something like: "Close and reopen the application to apply this change."

The helper text should have a dim-label class and be aligned underneath the switch, like in the elementary OS Mouse Settings page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the label and tried (I'm not an elementary user) to copy elementary OS layout. The result seems rater strange:
image

Maybe the white space that is present at the left is too big.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay for now. That panel needs some deep love and UI refresh, but we will do that later during the beta cycle since it's not a priority for now

@Alecaddd Alecaddd merged commit b0829bd into akiraux:master Jul 12, 2020
@Alecaddd Alecaddd mentioned this pull request Jul 12, 2020
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing the sidebar order.
2 participants