Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Text Tool #558

Closed
wants to merge 4 commits into from
Closed

Implement Text Tool #558

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2021 •
edited by ghost

PR Implements

As the title says this PR will Implement all the features of the CanvasText

Screenshots

Still in progress:
text-tool

Known Issues / Things To Do

  • Add double click to edit text
  • Add Default options for CanvasText in the settings
  • Add Color panel in left panel
  • Disable Insert Item when typing the font name
  • Add align options
  • Make size fixed when user changes width or height
  • Lint fixes
  • Create a font util and paste some of the font component
  • Change Left Panel Look, most of the added features are not yet implemented to the left panel
  • Auto and Fixed Sizing
  • Add Font Picker
  • Left Panel Italic Problem
  • Add Font Color Picker
  • Implement uppercase, lowercase, and capitalized options.
  • Implement italic
  • Font Weight Dropdown
  • Some Users may not have thin, ultra-thin, ultra-bold or heavy installed for selected font

Typography panel mock-up by @Alecaddd

116501348-684d6d00-a865-11eb-9730-f83211b56685

@ghost ghost marked this pull request as draft April 17, 2021 11:49
@ghost ghost changed the title Implement Font Weight, Italic, Underlined WIP: Implement Font Weight, Italic, Underlined Apr 17, 2021
@ghost ghost changed the title WIP: Implement Font Weight, Italic, Underlined WIP: Implement Text Tool Apr 20, 2021
ghost
ghost commented Apr 22, 2021
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some problems with the Italic and Left Panel that I am currently working on

@ghost ghost changed the title WIP: Implement Text Tool Implement Text Tool Apr 22, 2021
@ghost ghost marked this pull request as ready for review April 25, 2021 21:33
@ghost ghost closed this May 2, 2021
@ghost ghost reopened this May 2, 2021
Merge pull request #4 from akiraux/master
a471234 
Merge Akira branch 'master'
@Alecaddd Alecaddd marked this pull request as draft May 7, 2021 02:50
@Alecaddd
Copy link
Member

Alecaddd commented May 7, 2021

Converting this PR to a draft since we're not gonna merge it until we do some architectural rework.
Also this should be split in smaller PRs for easy review.

@ghost ghost marked this pull request as ready for review May 8, 2021 19:53
@ghost ghost marked this pull request as draft May 8, 2021 19:53
@Alecaddd
Copy link
Member

Closing this since we're dropping goocanvas. We can revisit it once we have the new UI working in main.

@Alecaddd Alecaddd closed this Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Alecaddd