Partials widgets rename #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbfraga
approved these changes
Jun 5, 2021
madjesc
pushed a commit
to madjesc/Akira
that referenced
this pull request
Jun 28, 2021
* Rename Partials to Widgets * Consistent block comment for all widgets * Disconnect events on destruction * Remove constructor and update window attribute to unowned * Update the ButtonImage widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
This is purely an architectural update to clean up some code and make sense of some areas.
No new feature or bug fix is in this PR.
Steps to Test
Use the app as usual and nothing should be broken.
This PR fixes/implements the following bugs/features:
Layoutsfolder toWidgets.The "important" change here is an experiment to implement destructors for those
Widgetsthat are created and removed pretty often. TheColorField.valashould be the focus of this review, alongside checking if changing the attribute of theWindowfrompublic weaktoprivate unownedaffects performance.