-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friends 2.7.6 without Post Kinds leads to segfault when accessing admin area with status/reposted Mastodon status #249
Comments
Anything I can do to help...please advise. I wrote Post Kinds. |
@dshanske Thank you for the plugin, I'm using it for the first time now that I have a project that works well with it. I clarified my issue based on some advice with a new section at the top. From my testing -- everything works when Post Kinds is enabled. It seems like my issue is only when Friends is enabled and Post Kinds is not enabled. If there is anything you want to confirm about my set up, please advise and I will get back to you. |
@nafnlj Sorry about that and thank you for your report so that we can try and fix it! A segfault is hard to debug since there is no error message. What version of PHP and which version of WordPress are you using? Since you mention there being an "ActivityPub post", does it mean the ActivityPub plugin is installed as well? Are there any other plugins? Also, what I am not fully grasping how a deactivated Post Kinds plugin plays a role here. Are you saying that if you uninstalled the Post Kinds plugin but activated the Friends plugin, the segfault does not occur? |
I've tried to reproduce it with https://playground.wordpress.net/?theme=sempress&plugin=friends&plugin=indieweb-post-kinds (you need to deactivate the Post Kinds plugin since it is automatically activated) but it never crashes. Would you be willing to provide me with an export ZIP of your WordPress installation (since it sounds like a bit of a test installation, I thought this might be ok), so that we could try and run this in the WordPress Playground to see if we can reproduce it there? |
@akirk Thank you for taking the time to respond and look into the issue. I appreciate all the work you, @dshanske, and others are putting into these tools and hope that my issue turns out to be helpful if it's not entirely unique to my set-up. Version InfoI forgot to include WP version and PHP info, my apologies. See below: ActivityPub ExplanationI apologize for not being clear on ActivityPub. See clarified explanation below:
I tried different scenarios involving disabling/enabling ActivityPub but it does not seem to have any influence on the issue. Clarifying Post Kinds role"Also, what I am not fully grasping how a deactivated Post Kinds plugin plays a role here. Are you saying that if you uninstalled the Post Kinds plugin but activated the Friends plugin, the segfault does not occur?" No, see scenarions below:
I tested Friends with all of the possible Post Formats configuration combinations in Settings but the issue remained consistent across the tests. Plugin ListBelow is my full plugin list with notes on a few -- at the moment I am still deciding what I want to use for the final site and what I can replace, hence some of the size: ActivityPub, ActivityStream extension, Async JavaScript, Autoptimize, Classic Editor, Classic Widgets, Friends, Gwolle Guestbook, IndieAuth, IndieWeb, Nodeinfo, plugin load filter, Post Kinds, Redirect Gravatar requests, Redirection, Redis Object Cache, Rewrite Rules Inspector, Simple Local Avatars, Syndication Links, The SEO Framework, TWTXT, Unbloater, VS Event List, VS Link Manager, WebFinger, Webmention, WebSub (FKA. PubSubHubbub), WP REST Cache, WP Super Cache, CUSTOM (https://giteacoffee.emucafe.org/naferrell/enable-pingbacks-for-wordpress-pages/src/branch/main/enable-pinpgacks-for-pages.php) Notes:
Testing Options
ConclusionThank you again for all your work and for looking into the issue. I look forward to being able to use all of these tools on my final set-up. Please let me know if you need any additional info. EDITS: Added extra note on ActivityPub, reduced plugin list to cover only those from IndieWeb suite or related to caching/WP features, excluded feed plugins and most security plugins, and clarified last section |
Additional testsI performed a few additional tests that may be helpful.
|
Additional InfoUpdate based on #208 I read issue #208 and noted that the problem seemed similar to my issue. The poster there made a specific reference to posts without titles. I confirmed that the lack of titles for Status posts on my site is connected to the issue on my site -- specifically the issue does not occur if WP-status format posts or posts reblogged from Mastodon have titles. See detailed outline below:
|
Thanks - I was just coming to see if I thought it was related to #208 which i opened. I don't have Cloudron and don't get a segfault, but do get a silent WP_DIE with no clear log of output. For me it happens any time I have reblogged or boosted statuses- I am not using "Post Kinds" Similarly, I only have the problem when the posts in question are active in the admin posts list - if I set them to draft or there are other newer posts so they are not showing on the first page, no error occurs - it's only when the posts list table is being drawn. I've been tying to find the time to go in an instrument the WP code happening at the point of drawing that table to isolate but haven't found the time. It "feels" like there is something about those kinds of posts (reblogs/boosts of statuses that came in via Friends and ActivityPub) that fails - something WordPress core expects to be set but isn't based on how thoses posts got created |
@nafnlj Could you send it to me to wpfriends249@kirk.at? Thanks! |
@akirk I have sent the email with plugins, themes, and posts as of 9/9/23 My site is now working as expected. I can have Friends active with Post Kinds enabled and one status post and access my post menu without the error. I have not made any changes to the site that would obviously implicate the issue -- the most significant changes I made were disabling compression in WP Super Cache and a few style changes to the child theme. You can see if the email I sent gives any clues. My best guess is that maybe adding a few additional post types somehow resolved the error -- e.g., I did make my first photo format post since I last observed the issue. Please let me know if there is any additional information that I could provide to help diagnose the issue generally even though it seems to be resolved in my case for the time being. |
I think I have finally been able to reproduce this and released a fix in 2.8.2 (#260). Thanks everyone for your patience and I hope this was really it. Please report if you still encounter the problems. |
Post Kinds does the same display change for empty titles, but it doesn't use the excerpt |
This issue pertains to Friends version 2.7.6.
I am running WordPress-Developer as a Cloudron app on a VPS server.
Quick Summary
(added after receiving advice that I should have a quick summary)
Overview
Console output
The following tests were performed under the following conditions:
I viewed my logs through Cloudron's UI while triggering the error by entering Admin > Posts with an offending post, Friends installed, and Post Kinds deactivated.
Test 1: Console Output for SemPress with child mods, Friends, and no Post Kinds
(I don't think the functions.php warning is relevant, on another test it showed up well after the seg fault, but including it just in case)
Base SemPress with no mods, Friends, and no Post Kinds
Finally, here is the console output with Query Monitor enabled (when Query Monitor is up, I get a critical error screen on Admin > Posts instead of the 504 screen from Cloudron)
Note that these issues occurred with SemPress, my child theme for SemPress, Autonomie, and the default Twenty Twenty-Three theme.
Conditions where segfault does not occur:
Additional Notes
Conclusion
Thank you much for all your work on the plugin and I look forward to using it going forward. If you need or want additional information, please advise and I will respond ASAP.
The text was updated successfully, but these errors were encountered: