Don't create a user when only following someone #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
force-pushed
the
subscriptions-userless
branch
from
5548a88
to
485b1ef
Compare
… to convert to/from subscription
akirk
force-pushed
the
subscriptions-userless
branch
from
78a7ee0
to
1048ddf
Compare
|
I've tested this for a while on my blog and it works well, so merging it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements something like a virutal user that is taxonomy based. New subscriptions are by default created as virtual users and (for now) you can manually convert existing subscriptions to virtual users on the Edit Friend page:
It can also be converted back (and will be as soon as you create a friend request from it).
The Friends functionality remains untouched, and I still need to work on the cases where we need to automatically convert the user. Of course you can opt to not use the friend functionality and disable incoming friend request by using some random codeword.