Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we support demos on the 5EPlay platform? #727

Closed
sean8610 opened this issue Jan 3, 2024 · 4 comments
Closed

Can we support demos on the 5EPlay platform? #727

sean8610 opened this issue Jan 3, 2024 · 4 comments
Labels
analyze enhancement

Comments

@sean8610
Copy link

sean8610 commented Jan 3, 2024

What problem is this solving

Unable to analyze demo from 5e platform

Proposed solution

The 5EPlay platform is another major platform in China besides the Perfect World,I suggest supporting it,Thanks a lot.

Describe alternatives you've considered

o
@akiver
Copy link
Owner

akiver commented Jan 6, 2024

I would need a bunch of CS2/CSGO demos from this platform.

Also some questions:

  1. Are there knife rounds?
  2. Are there overtimes?
  3. Are bots enabled?
  4. What game modes/match lengths are supported?

@sean8610
Copy link
Author

sean8610 commented Jan 7, 2024

1.Yes
2.Yes
3.Yes
4.Competitive mode/24 round

@sean8610
Copy link
Author

sean8610 commented Jan 7, 2024

http://gofile.me/6Yi2T/I0ZIi2eCy This is the download link of 5E platform demo. Created from my NAS.

akiver added a commit to markus-wa/demoinfocs-golang that referenced this issue Jan 13, 2024
@akiver
fix: possible invalid weapon in kill events
d7f0779 
Following #490.

- It's not always a suffix - it can be a prefix.
- The suffix/prefix is not the killer's name but the words `vip` or `default` (there may be others).
- The team's name may also be part of the suffix/prefix

Noticed with demos coming from akiver/cs-demo-manager#727.
Example with this one https://mega.nz/file/LZFlhATB#aCO-g1hoGohndAKXJVUHzLCcbyzH-n7cGi9ZWO5UdSM.

Weapon's name from game events:
```
5e_vip_usp_silencer
5e_default_deagle
5e_vip_xm1014
5e_default_mp9
5e_default_galilar
5e_vip_m4a1_silencer
5e_vip_ak47
```
@akiver akiver mentioned this issue Jan 13, 2024
Merged
akiver added a commit to markus-wa/demoinfocs-golang that referenced this issue Jan 13, 2024
@akiver
fix: possible invalid weapon in kill events
133d081 
Following #490.

- It's not always a suffix - it can be a prefix.
- The suffix/prefix is not the killer's name but the words `vip` or `default` (there may be others).
- The team's name may also be part of the suffix/prefix

Noticed with demos coming from akiver/cs-demo-manager#727.
Example with this one https://mega.nz/file/LZFlhATB#aCO-g1hoGohndAKXJVUHzLCcbyzH-n7cGi9ZWO5UdSM.

Weapon's name from game events:
```
5e_vip_usp_silencer
5e_default_deagle
5e_vip_xm1014
5e_default_mp9
5e_default_galilar
5e_vip_m4a1_silencer
5e_vip_ak47
```
akiver added a commit to akiver/cs-demo-analyzer that referenced this issue Jan 13, 2024
@akiver
fix: do not assign teams names if they are the same
20b0116 
It's the case with 5Eplay demos.

ref akiver/cs-demo-manager#727
akiver added a commit to markus-wa/demoinfocs-golang that referenced this issue Jan 14, 2024
@akiver
fix: set player connected flag to false when controller is destroyed
713ae71 
Bot controller entities can be destroyed:

```
96322 player_controller_destroy 12 Baroud 0
107866 player_controller_destroy 14 Bank 0
```

If we don't update the prop `Connected`, the bot will still be in the slice returned by `Playing()`.
As a result, calling a player's function that relies on its pawn entity such as `EquipmentValueCurrent()` may result in a panic as the pawn doesn't exists anymore.

Noticed with this demo https://mega.nz/file/uBdF3TBT#aoGpmJ6PKaNIMqPdZsVxHyhiv7DbxO3M9jJNWAOIhb0 and the following code:

```go
p.RegisterEventHandler(func(e events.RoundStart) {
  fmt.Println(p.GameState().TeamCounterTerrorists().CurrentEquipmentValue())
  fmt.Println(p.GameState().TeamTerrorists().CurrentEquipmentValue())
})
```

ref akiver/cs-demo-manager#727
@akiver akiver mentioned this issue Jan 14, 2024
Merged
akiver added a commit to markus-wa/demoinfocs-golang that referenced this issue Jan 14, 2024
@akiver
fix: set player connected flag to false when controller is destroyed
3251e1c 
Bot controller entities can be destroyed:

```
96322 player_controller_destroy 12 Baroud 0
107866 player_controller_destroy 14 Bank 0
```

If we don't update the prop `Connected`, the bot will still be in the slice returned by `Playing()`.
As a result, calling a player's function that relies on its pawn entity such as `EquipmentValueCurrent()` may result in a panic as the pawn doesn't exists anymore.

Noticed with this demo https://mega.nz/file/uBdF3TBT#aoGpmJ6PKaNIMqPdZsVxHyhiv7DbxO3M9jJNWAOIhb0 and the following code:

```go
p.RegisterEventHandler(func(e events.RoundStart) {
  fmt.Println(p.GameState().TeamCounterTerrorists().CurrentEquipmentValue())
  fmt.Println(p.GameState().TeamTerrorists().CurrentEquipmentValue())
})
```

ref akiver/cs-demo-manager#727
akiver added a commit to akiver/cs-demo-analyzer that referenced this issue Jan 16, 2024
@akiver
feat: add 5EPlay demos support
5ccfdb7 
ref akiver/cs-demo-manager#727
@akiver akiver mentioned this issue Jan 16, 2024
Merged
akiver added a commit to akiver/cs-demo-analyzer that referenced this issue Jan 16, 2024
@akiver
feat: add 5EPlay demos support
c32773a 
ref akiver/cs-demo-manager#727
akiver added a commit that referenced this issue Jan 16, 2024
@akiver
feat: add 5EPlay demos support
b1a4c64 
ref #727
@akiver
Copy link
Owner

akiver commented Jan 17, 2024

Added in v3.2.0.

@akiver akiver closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyze enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akiver @sean8610