Feature Request: Own window separator

[Mariappan]

Since neovim supports external window management, do you have plans to add this support in gonvim ?

Also floating window support and virtual text support

[akiyosi]

HI,

I plan to add the feature in v0.4.0.
But those features, the floating window and the virtual text should be work in the current version as well.

[Mariappan]

May be not in the remote attachment ?

I tried to use git-p.nvim plugin which seems to work in terminal version. But with gonvim in remote attachment, it does not seems to work 🤔

[akiyosi]

Umm..., I do not use those features in remote attachments. 🤔
I will check.

[akiyosi]

In passing, is remote nvim using 0.4.0?

[Mariappan]

Yes it is
NVIM v0.4.0-430-g8698830cb Build type: RelWithDebInfo LuaJIT 2.0.5

[akiyosi]

I checked the feature; the floating window and the virtual text with the remote attachment and confirmed that it works.
I did not work well the git-p.nvim.
Instead I checked with Shougo/deol.nvim and w0rp/ale.

[Mariappan]

@akiyosi I am seeing there are some checkins in the multi-grid branch.
Is it in workable condition?
Any chance I get a linux binary to test 😃

[akiyosi]

@Mariappan
Yes, It is work with nvim v0.4.0.
But currentry, there is a bug. See neovim/neovim#9899

[Mariappan]

Cool @akiyosi
Can you please share the linux zip then ?
I can start testing. I dont use tabs much so it wont impact me much

[akiyosi]

Ummm,
Is it possible to build on your machine?
I think it is not at the stage that can share the binary yet.😥
There are still bugs in neovim's Multigrid UI, and the implementation policy on the GUI side has not been clearly obtained.

[Mariappan]

@akiyosi
After some boring stuff, compiled successfully the multigrid branch.
And I found the reason for the window close problem too. Raised a PR to fix it.

#55

Once you verify this fix, you can close the neovim/neovim#9899

[Mariappan]

This multigrid-branch is pretty much usable. I am using for half an hour and it looks fine.

One compelling thing needed urgently is to implement the window separators for horizontal and vertical split. It looks aweful

[akiyosi]

@Mariappan
Thank you very much.
Perhaps it was added in the debugging of Multigrid UI events in old commit of nvim.😅

One compelling thing needed urgently is to implement the window separators for horizontal and vertical split. It looks aweful

I think the window separator is equivalent to the original vim at present, is it so aweful?

[Mariappan]

Please take a look 😢
In the above pic, there are two splits, one horizontal split and then one vertical split and three windows
But very difficult to distinguish between them

[akiyosi]

Umm, ok.
I will consider 😁

[akiyosi]

I made minimal changes to draw window separators now 31ad7c5
I want your opinion.

[Mariappan]

Thanks @akiyosi. I have tried your changes and it looks fine.
In vertical separator, the file name is shown which has to be removed, which i believe, you will fix it in the further updates.

I have one doubt, are we not creating separate windows, for splits ?
Are we using same one window for all the splits and just drawing the line to create/visualise the splits.
Sorry I don't understand the design

[akiyosi]

@Mariappan
Currently, gonvim creates a window-widget for each neovim window.
In the Multigrid UI, the window separator(and file name, ruler info in the statusline) is notified as an grid-event with a special grid ID 1, and the current separator implementation is drawing for window widget with a grid ID 1.

[Mariappan]

Thanks @akiyosi I have tried the latest changes and it looks awesome.
This is my daily driver now. Thanks for addressing this in very short time 😄

There is one bug in gonvimfuzzyAg display which I am tracking now.
Will raise pull request once i found RC

[Mariappan]

Hi @akiyosi There is some cursor bug in 0.4.0 branch currently
When you move the arrows using left and right arrow keys, I am seeing this .

Also cursor shape move from block to vertical

[Mariappan]

[akiyosi]

@Mariappan
Thank you for your testing!
I am very grateful.

Also cursor shape move from block to vertical

I think it is default guicursor value behavior.
You can confirm the same behavior in macvim.
If you want to change the behavior, you should set the guicursor option.
command-line Normal and command-line Insert are the targets of setting, especially for the behavior you pointed out🙂

By the way, I fixed the cursor position bug 0df8f9d