Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multigrid UI :quit closes multiple windows in tab #9899

Closed
akiyosi opened this issue Apr 13, 2019 · 5 comments
Closed

Multigrid UI :quit closes multiple windows in tab #9899

akiyosi opened this issue Apr 13, 2019 · 5 comments
Labels
ui ui-extensibility UI extensibility, events, protocol

Comments

@akiyosi
Copy link

akiyosi commented Apr 13, 2019

  • nvim --version: v0.4.0-321-g9a1675b06

  • Vim (version: ) behaves differently? yes

  • Operating system/version: macOS

  • Terminal name/version: Not using a terminal

Steps to reproduce using nvim -u NORC

gonvim [-u NONE]
:e /path/to/somefile.vim
:tabnew
gt
:vsp
:q

Actual behaviour

The first tab disappears when you do the abobe steps

Expected behaviour

The first tab should remain because it split the window with :vsp.

The following is the state of reproduction.
I'm testing with gonvim

nvim commit: 9a1675b06:
Apr-13-2019 18-33-25

nvim commit: 0aba4d825:
Apr-13-2019 18-32-55

@justinmk
Copy link
Member

is there something significant about 9a1675b and 0aba4d8? Was the behavior bisected to one of those commits? I can't tell from the gifs.

@justinmk justinmk added ui ui-extensibility UI extensibility, events, protocol labels Apr 13, 2019
@akiyosi
Copy link
Author

akiyosi commented Apr 14, 2019

I haven't seen enough of these commit differences, but the behavior of the GUI in multigrid UI seems to change between those commits.

@bfredl bfredl changed the title Multigrid UI behavior is not compliant with VIM Multigrid UI :quit closes multiple windows in tab Apr 14, 2019
@justinmk
Copy link
Member

Can you write a Lua screen test showing the problem? See test/functional/example_spec.lua for an example.

You can run the test like this:

TEST_FILE=test/functional/example_spec.lua make functionaltest

@akiyosi
Copy link
Author

akiyosi commented Apr 16, 2019

I confirmed that this issue can be detected by neovim's test test/functional/ui/multigrid_spec.lua. That is, even with the following operations in multigrid_spec.lua, problems occur on the GUI side but the test succeeds.

vsplit
wincmd l
split
wincmd h
q

I trace the events notified to the GUI side in detail, and it seems that grid_destroy has been sent for two grids by the operation q in the GUI. I have not identified the cause why it is sent twice.

I continue to investigate this issue.

@akiyosi
Copy link
Author

akiyosi commented May 14, 2019

I'm very very sorry.😓
This was a bug on the GUI side. I was sending close command to nvim on the win_close.
@Mariappan solved this problem.

@akiyosi akiyosi closed this as completed May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui ui-extensibility UI extensibility, events, protocol
Projects
None yet
Development

No branches or pull requests

2 participants