Multiple version bumps, extracted version values and gradle upgrade. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennru
approved these changes
May 5, 2020
| @@ -38,6 +38,10 @@ configurations { | |||
|
|
|||
| dependencies { | |||
|
|
|||
| compile 'com.typesafe.akka:akka-discovery_$scala_major_version$:$akka_version$' | |||
There was a problem hiding this comment.
Maybe do the versions += [ ScalaBinary... thing here?
If we want to keep gradle around...
There was a problem hiding this comment.
I'll do in a separate PR.
I'm trying to align both g8 templates first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #35
Related to akka/akka-grpc-quickstart-java.g8#32
Some changes are to bring this
.g8template closer to the java counterpart.NOTE: I'm purposedly not bumping any dependency on the project itself and focusing this PR on the generated code only.