Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection errors not reported for akka-http client backend #1423

Closed
jrudolph opened this issue Aug 3, 2021 · 4 comments
Closed

Connection errors not reported for akka-http client backend #1423

jrudolph opened this issue Aug 3, 2021 · 4 comments
Assignees
Labels
akka-http-client bug Something isn't working
Milestone

Comments

@jrudolph
Copy link
Member

jrudolph commented Aug 3, 2021

Connection errors are not reported i.e. the response Future of a call is not failed.

The reason is that currently the akka-http PersistentConnection fails the connection stream if the connection fails ultimately. When that happens, we might have a request on the akka-http side outstanding (and more in the queue on the akka-grpc side).

We could try to report an error on the akka-http side but that is prone to race conditions (send error response vs stream failure, but also possibly send new request vs. stage failed).

To add that feature in akka-grpc, we need to keep track of ongoing requests. Is that what we want?

See also akka/akka-http#3892.

@jrudolph jrudolph added bug Something isn't working akka-http-client labels Aug 3, 2021
@johanandren johanandren self-assigned this Aug 25, 2023
@johanandren
Copy link
Member

johanandren commented Aug 25, 2023

Trying out a possible upstream solution/precondition to solution here: akka/akka-http#4299

@johanandren
Copy link
Member

Better upstream fix for the request triggering the failure: akka/akka-http#4322

@jtjeferreira
Copy link
Contributor

@johanandren Since akka/akka-http#4322 was merged and released this is no longer needed?

@johanandren
Copy link
Member

There is still an open PR with further fixes needed waiting (#1851)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-http-client bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants