-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection errors not reported for akka-http client backend #1423
Comments
Trying out a possible upstream solution/precondition to solution here: akka/akka-http#4299 |
Better upstream fix for the request triggering the failure: akka/akka-http#4322 |
johanandren
added a commit
that referenced
this issue
Dec 14, 2023
@johanandren Since akka/akka-http#4322 was merged and released this is no longer needed? |
There is still an open PR with further fixes needed waiting (#1851) |
johanandren
added a commit
that referenced
this issue
Feb 28, 2024
johanandren
added a commit
that referenced
this issue
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Connection errors are not reported i.e. the response
Future
of a call is not failed.The reason is that currently the akka-http
PersistentConnection
fails the connection stream if the connection fails ultimately. When that happens, we might have a request on the akka-http side outstanding (and more in the queue on the akka-grpc side).We could try to report an error on the akka-http side but that is prone to race conditions (send error response vs stream failure, but also possibly send new request vs. stage failed).
To add that feature in akka-grpc, we need to keep track of ongoing requests. Is that what we want?
See also akka/akka-http#3892.
The text was updated successfully, but these errors were encountered: