Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shaded netty #57

Merged
merged 2 commits into from Mar 5, 2018
Merged

Use shaded netty #57

merged 2 commits into from Mar 5, 2018

Conversation

raboof
Copy link
Member

@raboof raboof commented Mar 2, 2018 •
edited

Except for the interop tests (refs #1)

@raboof
Use shaded netty (#1)
87da2fe 
Except for the interop tests
@raboof raboof changed the title Use shaded netty (#1) Use shaded netty Mar 2, 2018
ktoso
ktoso approved these changes Mar 3, 2018
View reviewed changes
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, one nit though

project/Dependencies.scala Outdated

val grpcCore = "io.grpc" % "grpc-core" % Versions.grpc
val grpcNetty = "io.grpc" % "grpc-netty" % Versions.grpc
val grpcNetty = "io.grpc" % "grpc-netty-shaded" % Versions.grpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call the val shaded?

@raboof raboof merged commit ba5c596 into master Mar 5, 2018
@raboof raboof deleted the removeScalapbGrpcRuntime branch March 5, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@octonato octonato octonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @ktoso @octonato