Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused values #847

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Remove unused values #847

merged 2 commits into from
Mar 11, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Mar 4, 2020

Let's merge #829 first to avoid some conflicts

@raboof raboof force-pushed the no-unused-imports branch 5 times, most recently from a59e3c2 to 0077617 Compare March 5, 2020 15:08
Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codec: Codec,
system: ActorSystem,
eHandler: Function[ActorSystem, Function[Throwable, Trailers]] = GrpcExceptionHandler.defaultMapper)
: HttpResponse =
GrpcResponseHelpers(e.asScala, scalaAnonymousPartialFunction(eHandler))(m, mat, Identity, system)
GrpcResponseHelpers(e.asScala, scalaAnonymousPartialFunction(eHandler))(m, codec, system)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@raboof raboof force-pushed the no-unused-imports branch 2 times, most recently from 849c6b4 to 8b7b5a1 Compare March 9, 2020 17:01
@raboof
Copy link
Member Author

raboof commented Mar 9, 2020

(rebased on #829, let's rebase again when that's merged)

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@raboof raboof merged commit 8825278 into akka:master Mar 11, 2020
@raboof raboof deleted the no-unused-imports branch March 11, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants