-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused values #847
Remove unused values #847
Conversation
a59e3c2
to
0077617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
codec: Codec, | ||
system: ActorSystem, | ||
eHandler: Function[ActorSystem, Function[Throwable, Trailers]] = GrpcExceptionHandler.defaultMapper) | ||
: HttpResponse = | ||
GrpcResponseHelpers(e.asScala, scalaAnonymousPartialFunction(eHandler))(m, mat, Identity, system) | ||
GrpcResponseHelpers(e.asScala, scalaAnonymousPartialFunction(eHandler))(m, codec, system) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
849c6b4
to
8b7b5a1
Compare
(rebased on #829, let's rebase again when that's merged) |
8b7b5a1
to
2a9bdd4
Compare
2a9bdd4
to
d82e3af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Let's merge #829 first to avoid some conflicts