idle-timeout became broken between 10.0.4 and 10.0.5?

[ktoso]

It seems we may have broken idle timeouts in 10.0.5, I will look into this immediately,

Notes:

It appears that this might indeed be a bug introduced during a change to make the transport API more pluggable. You can see that in v10.0.4 Tcp().outgoingConnection explicitly sets the idleTimeout, whereas in the current master it relies on that to be set by the passed in, pluggable transport. This would be ok as @ClientTransport.TCPTransport utilizes the passed in idleTimeout which the transport is utilized by the PoolInterfaceActor after having been created by the ConnectionSettings here. So, all that said, at a fair review it looks like the timeout should still be handled appropriately as everything seems to be instantiated at the correct times. So we will have to dig a bit deeper to determine if and how this pluggable change affected items such as timeout.

[ktoso]

Working on it

[jrudolph]

Ok, I see what the problem is here. It has nothing to do with passing the settings around but it's this particular usage of setting the idle-timeout which doesn't work any more:

val poolSettings = ConnectionPoolSettings(system).withConnectionSettings( 
  ClientConnectionSettings(system) 
    .withConnectingTimeout(6.seconds) 
    .withIdleTimeout(6.seconds) 
)

Setting the idle-timeout from application.conf should still work.

The reason that it doesn't work any more is that ConnectionPoolSettings(system) already configures the transport with the idle-timeout as given in the config file and withConnectionSettings doesn't make sure to apply a changed idle-timeout also to the transport.

[ktoso]

I would still call that "passing settings around", but yeah - it's about that case.

The reason that it doesn't work any more is that ConnectionPoolSettings(system) already configures the transport with the idle-timeout as given in the config file and withConnectionSettings doesn't make sure to apply a changed idle-timeout also to the transport.

Yes, which I think I was addressing in my PR, though it's been a week so lemme try to review it myself again and see if really fixing the root issue.