-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idle-timeout became broken between 10.0.4 and 10.0.5? #1012
Comments
Working on it |
Ok, I see what the problem is here. It has nothing to do with passing the settings around but it's this particular usage of setting the idle-timeout which doesn't work any more: val poolSettings = ConnectionPoolSettings(system).withConnectionSettings(
ClientConnectionSettings(system)
.withConnectingTimeout(6.seconds)
.withIdleTimeout(6.seconds)
) Setting the idle-timeout from The reason that it doesn't work any more is that |
I would still call that "passing settings around", but yeah - it's about that case.
Yes, which I think I was addressing in my PR, though it's been a week so lemme try to review it myself again and see if really fixing the root issue. |
A transport is now a static constant function value that gets passed all parameters at connection time. That fixes akka#1012 where client connection settings were both kept redundantly inside the transport and inside the settings. It's now also possible to specify the localAddress inside the settings. Methods in the Http entrypoint that allow specifying the localAddress explicitly will override whatever was given in the settings. In the future we'd like to get rid of all those parameters to simplify entrypoint signatures in Http.
…imeout Revamp SPI / API of ClientTransport infrastructure to fix #1012 and to simplify API
A transport is now a static constant function value that gets passed all parameters at connection time. That fixes akka#1012 where client connection settings were both kept redundantly inside the transport and inside the settings. It's now also possible to specify the localAddress inside the settings. Methods in the Http entrypoint that allow specifying the localAddress explicitly will override whatever was given in the settings. In the future we'd like to get rid of all those parameters to simplify entrypoint signatures in Http.
It seems we may have broken idle timeouts in 10.0.5, I will look into this immediately,
Notes:
The text was updated successfully, but these errors were encountered: