Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP status code 418 #1206

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Add HTTP status code 418 #1206

merged 2 commits into from
Jun 26, 2017

Conversation

ametrocavich
Copy link
Contributor

Added support for status code 418 according to https://tools.ietf.org/html/rfc2324

@ametrocavich
Add HTTP status code 418
00cc49a 
Added support for status code 418 according to https://tools.ietf.org/html/rfc2324
@lightbend-cla-validator
Copy link

Hi @ametrocavich,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@akka-ci
Copy link

akka-ci commented Jun 16, 2017

Can one of the repo owners verify this patch?

@ametrocavich
Copy link
Contributor Author

I signed the CLA

@jlprat
Copy link
Member

jlprat commented Jun 16, 2017

OK TO TEST

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jun 16, 2017
@akka-ci
Copy link

akka-ci commented Jun 16, 2017

Test PASSed.

ktoso
ktoso reviewed Jun 17, 2017
View reviewed changes
akka-http-core/src/main/scala/akka/http/scaladsl/model/StatusCode.scala
@@ -142,6 +142,7 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val UnsupportedMediaType = reg(c(415)("Unsupported Media Type", "The request entity has a media type which the server or resource does not support."))
val RequestedRangeNotSatisfiable = reg(c(416)("Requested Range Not Satisfiable", "The client has asked for a portion of the file, but the server cannot supply that portion."))
val ExpectationFailed = reg(c(417)("Expectation Failed", "The server cannot meet the requirements of the Expect request-header field."))
val ImATeapot = reg(c(418)("I'm a teapot", "The resulting entity body MAY be short and stout."))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is seriously meant to get in then the PR is missing Java API ;-)
You'd have to mirror it in javadsl/model/StatusCodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 19, 2017
@akka-ci
Copy link

akka-ci commented Jun 19, 2017

Test PASSed.

jlprat
jlprat reviewed Jun 19, 2017
View reviewed changes
Copy link
Member

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, for the sake of implementing the specs, LGTM :?)

@jrudolph
Copy link
Member

Great first addition, @ametrocavich ;) ☕ 🍵

@jrudolph jrudolph merged commit a46958b into akka:master Jun 26, 2017
@jrudolph jrudolph added this to the 10.0.9 milestone Jun 26, 2017
@ametrocavich ametrocavich deleted the patch-1 branch June 27, 2017 15:55
tomrf1 pushed a commit to tomrf1/akka-http that referenced this pull request Aug 13, 2017
@ametrocavich @tomrf1
Add HTTP status code 418 (akka#1206)
402833e 
Added support for status code 418 according to https://tools.ietf.org/html/rfc2324
@btomala
Copy link
Contributor

btomala commented May 8, 2018

This status is missing in the 10.1.1 version. Is it regression or deliberate action?

@ktoso
Copy link
Member

ktoso commented May 8, 2018

Please be specific. Missing where? It’s srill present in sources: https://github.com/akka/akka-http/blob/master/akka-http-core/src/main/scala/akka/http/scaladsl/model/StatusCode.scala

@btomala
Copy link
Contributor

btomala commented May 8, 2018

Sorry, my mistake. I checked twice but on the master @ametrocavich fork. And IntelliJ said it is missing - strange, probably import wrong source code. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso left review comments

@jlprat jlprat jlprat left review comments

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.0.9
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ametrocavich @lightbend-cla-validator @akka-ci @jlprat @jrudolph @btomala @ktoso