Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpResponseParser returns invalid status code for statuses without reason phrase #1251

Closed
mateuszgruszczynski opened this issue Jun 29, 2017 · 1 comment
Closed

HttpResponseParser returns invalid status code for statuses without reason phrase #1251

mateuszgruszczynski opened this issue Jun 29, 2017 · 1 comment
Labels
3 - in progress Someone is working on this ticket bug help wanted Identifies issues that the core team will likely not have time to work on
Milestone
10.0.10

Comments

@mateuszgruszczynski
Copy link
Contributor

When server responds with HTTP status without reason phase then it is not parsed as status code, but only skipped, so always default statusCode value (200 OK) is returned.
mateuszgruszczynski pushed a commit to mateuszgruszczynski/akka-http that referenced this issue Jun 29, 2017
HttpResponseParser - add parsing for status codes without reason akka…
5249d0f 
…#1251
mateuszgruszczynski pushed a commit to mateuszgruszczynski/akka-http that referenced this issue Jun 29, 2017
HttpResponseParser - add parsing for status codes without reason (akk…
c3666e7 
…a#1251)
@mateuszgruszczynski mateuszgruszczynski mentioned this issue Jun 29, 2017
Merged
@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted bug labels Jun 30, 2017
@ktoso
Copy link
Member

ktoso commented Jun 30, 2017

Thanks for spotting this and the fix!

@ktoso ktoso added this to the 10.0.10 milestone Jun 30, 2017
@ktoso ktoso added 3 - in progress Someone is working on this ticket help wanted Identifies issues that the core team will likely not have time to work on and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Jun 30, 2017
raboof pushed a commit that referenced this issue Jun 30, 2017
@mateuszgruszczynski @raboof
HttpResponseParser - add parsing for status codes without reason (#1251…
075913c 
…) (#1252)
ktoso pushed a commit to ktoso/akka-http that referenced this issue Jul 18, 2017
@mateuszgruszczynski @ktoso
HttpResponseParser - add parsing for status codes without reason (akk…
c9c4b8a 
…a#1251) (akka#1252)
tomrf1 pushed a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017
@mateuszgruszczynski @tomrf1
HttpResponseParser - add parsing for status codes without reason (akk…
ec41dc6 
…a#1251) (akka#1252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - in progress Someone is working on this ticket bug help wanted Identifies issues that the core team will likely not have time to work on
Projects
None yet
Milestone
10.0.10
Development

No branches or pull requests
2 participants
@ktoso @mateuszgruszczynski