Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Dilated Timeouts for Java Testkit #1271

Closed
jlprat opened this issue Jul 5, 2017 · 4 comments
Closed

Provide Dilated Timeouts for Java Testkit #1271

jlprat opened this issue Jul 5, 2017 · 4 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:java Issues related to the Java DSL
Milestone

Comments

@jlprat
Copy link
Member

jlprat commented Jul 5, 2017

As discovered in #1238, Java Testkit can't benefit of the dilated tests.
The current timeout when using Scala Testkit is 1 second (dilated) while the Java one is just 3 seconds.

In order to let Java Testkit use dilated, the RouteTest should extend JavaTestKit (that is where the dilated method is defined).

@jlprat jlprat added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:java Issues related to the Java DSL labels Jul 5, 2017
@jiminhsieh
Copy link
Contributor

I found JavaTestKit prepare to deprecate since Akka 2.5.0. It would be replace by akka.testkit.javadsl.TestKit. Do we still need to fix this? I also found akka.http.javadsl.testkit.RouteTest could not just simply extend JavaTestKit. It already extended abstract class - akka.http.javadsl.server.AllDirectives. Maybe I just misunderstand what your idea. Thanks!

@jlprat
Copy link
Member Author

jlprat commented Jul 6, 2017

That might well be (deprecation)! I guess I was checking the 2.4.x series (which Akka HTTP depends on).
Basically, what I meant is that https://github.com/akka/akka-http/blob/master/akka-http-testkit/src/main/scala/akka/http/javadsl/testkit/RouteTest.scala#L36 this should have a dilated timeout.

@raboof
Copy link
Member

raboof commented Jul 6, 2017

(just to clarify, in case someone stumbles upon this ticket: while Akka HTTP indeed depends on Akka 2.4.x, it also works with Akka 2.5.x as those are binary compatible. We plan to update the dependency as part of #1151)

jiminhsieh added a commit to jiminhsieh/akka-http that referenced this issue Jul 6, 2017
jiminhsieh added a commit to jiminhsieh/akka-http that referenced this issue Aug 10, 2017
jiminhsieh added a commit to jiminhsieh/akka-http that referenced this issue Sep 26, 2017
@raboof raboof added this to the 10.0.11 milestone Oct 11, 2017
@jrudolph
Copy link
Member

Fixed in #1272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:java Issues related to the Java DSL
Projects
None yet
Development

No branches or pull requests

4 participants