New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Dilated Timeouts for Java Testkit #1271

Closed
jlprat opened this Issue Jul 5, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@jlprat
Member

jlprat commented Jul 5, 2017

As discovered in #1238, Java Testkit can't benefit of the dilated tests.
The current timeout when using Scala Testkit is 1 second (dilated) while the Java one is just 3 seconds.

In order to let Java Testkit use dilated, the RouteTest should extend JavaTestKit (that is where the dilated method is defined).

@jiminhsieh

This comment has been minimized.

Show comment
Hide comment
@jiminhsieh

jiminhsieh Jul 6, 2017

Contributor

I found JavaTestKit prepare to deprecate since Akka 2.5.0. It would be replace by akka.testkit.javadsl.TestKit. Do we still need to fix this? I also found akka.http.javadsl.testkit.RouteTest could not just simply extend JavaTestKit. It already extended abstract class - akka.http.javadsl.server.AllDirectives. Maybe I just misunderstand what your idea. Thanks!

Contributor

jiminhsieh commented Jul 6, 2017

I found JavaTestKit prepare to deprecate since Akka 2.5.0. It would be replace by akka.testkit.javadsl.TestKit. Do we still need to fix this? I also found akka.http.javadsl.testkit.RouteTest could not just simply extend JavaTestKit. It already extended abstract class - akka.http.javadsl.server.AllDirectives. Maybe I just misunderstand what your idea. Thanks!

@jlprat

This comment has been minimized.

Show comment
Hide comment
@jlprat

jlprat Jul 6, 2017

Member

That might well be (deprecation)! I guess I was checking the 2.4.x series (which Akka HTTP depends on).
Basically, what I meant is that https://github.com/akka/akka-http/blob/master/akka-http-testkit/src/main/scala/akka/http/javadsl/testkit/RouteTest.scala#L36 this should have a dilated timeout.

Member

jlprat commented Jul 6, 2017

That might well be (deprecation)! I guess I was checking the 2.4.x series (which Akka HTTP depends on).
Basically, what I meant is that https://github.com/akka/akka-http/blob/master/akka-http-testkit/src/main/scala/akka/http/javadsl/testkit/RouteTest.scala#L36 this should have a dilated timeout.

@raboof

This comment has been minimized.

Show comment
Hide comment
@raboof

raboof Jul 6, 2017

Member

(just to clarify, in case someone stumbles upon this ticket: while Akka HTTP indeed depends on Akka 2.4.x, it also works with Akka 2.5.x as those are binary compatible. We plan to update the dependency as part of #1151)

Member

raboof commented Jul 6, 2017

(just to clarify, in case someone stumbles upon this ticket: while Akka HTTP indeed depends on Akka 2.4.x, it also works with Akka 2.5.x as those are binary compatible. We plan to update the dependency as part of #1151)

jiminhsieh added a commit to jiminhsieh/akka-http that referenced this issue Jul 6, 2017

jiminhsieh added a commit to jiminhsieh/akka-http that referenced this issue Aug 10, 2017

jiminhsieh added a commit to jiminhsieh/akka-http that referenced this issue Sep 26, 2017

raboof added a commit that referenced this issue Oct 11, 2017

@raboof raboof added this to the 10.0.11 milestone Oct 11, 2017

@jrudolph

This comment has been minimized.

Show comment
Hide comment
@jrudolph

jrudolph Nov 30, 2017

Member

Fixed in #1272.

Member

jrudolph commented Nov 30, 2017

Fixed in #1272.

@jrudolph jrudolph closed this Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment