Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HttpApp.startServer(host, port, system) #1294

Closed
ktoso opened this issue Jul 21, 2017 · 4 comments
Closed

Add HttpApp.startServer(host, port, system) #1294

ktoso opened this issue Jul 21, 2017 · 4 comments
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding help wanted Identifies issues that the core team will likely not have time to work on t:http2 Issues related to support HTTP2
Milestone
10.0.10

Comments

@ktoso
Copy link
Member

ktoso commented Jul 21, 2017

Currently we require passing in the config and system if one wants to pass in system.
I just want to pass in the system, and have the default config.

Encountered this painfully in real code where I needed to start an HttpApp from a Java codebase, but the server was Scala. Creating the Scala settings object is a huge pain in Java due to the type system not managing well the apply return type of Akka Extensions..

Adding:

def startServer(host: String, port: Int, system: ActorSystem): Unit = {
    super.startServer(host, port, ServerSettings(system.settings.config), system)
  }

Will enable this use case, and is also just a missing overload I think
@ktoso
Copy link
Member Author

ktoso commented Jul 21, 2017

FYI @jlprat

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding help wanted Identifies issues that the core team will likely not have time to work on t:http2 Issues related to support HTTP2 labels Jul 21, 2017
@ktoso ktoso added this to the 10.0.10 milestone Jul 21, 2017
@jlprat
Copy link
Member

jlprat commented Jul 21, 2017

I completely agree. I will take this one :) This overloaded crossed my mind as well and I thought I added an issue for it.

@ktoso
Copy link
Member Author

ktoso commented Jul 21, 2017 via email

@jlprat jlprat added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Jul 21, 2017
jlprat added a commit to jlprat/akka-http that referenced this issue Jul 23, 2017
@jlprat
+htp Provide overloaded HttpApp.startServer method with system akka#1294
8018750 


Issue: akka#1294
Add overloaded HttpApp.startServer method
Add docs for this new method
Add tests for this new method
@jlprat jlprat mentioned this issue Jul 23, 2017
Merged
jlprat added a commit that referenced this issue Jul 25, 2017
@jlprat
+htp Provide overloaded HttpApp.startServer method with system #1294 (#…
b349d5c 
…1299)

* +htp Provide overloaded HttpApp.startServer method with system #1294

Issue: #1294
Add overloaded HttpApp.startServer method
Add docs for this new method
Add tests for this new method

* Protect against null system

* =htp document what null or None mean in HttpApp's system

* =htp Document what null/None mean in HttpApp system passing in

* fix trailing whitespaces
@jlprat
Copy link
Member

jlprat commented Jul 25, 2017

Closed via #1299

@jlprat jlprat closed this as completed Jul 25, 2017
@jlprat jlprat removed the 3 - in progress Someone is working on this ticket label Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding help wanted Identifies issues that the core team will likely not have time to work on t:http2 Issues related to support HTTP2
Projects
None yet
Milestone
10.0.10
Development

No branches or pull requests
2 participants
@ktoso @jlprat