Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for Forwarded Header #1377

Open
1 of 2 tasks
jlprat opened this issue Aug 22, 2017 · 4 comments
Open
1 of 2 tasks

Provide support for Forwarded Header #1377

jlprat opened this issue Aug 22, 2017 · 4 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted hackathon Issues that could be tackled during a hackathon help wanted Identifies issues that the core team will likely not have time to work on t:core Issues related to the akka-http-core module

Comments

@jlprat
Copy link
Member

jlprat commented Aug 22, 2017 •
edited
Loading

Currently, Akka HTTP doesn't support the standard header Forwarded, but only one of the de-facto standard X-Forwarded-For header that is only part of the standard Forwarded.

It would be good to add support for Forwarded header as described in https://tools.ietf.org/html/rfc7239

Additionally, it might be also good to implement X-Forwarded-Proto and X-Forwarded-Host:

Headers added

  • X-Forwarded-Proto and X-Forwarded-Host
  • Forwarded
@jlprat jlprat added help wanted Identifies issues that the core team will likely not have time to work on discuss Tickets that need some discussion before proceeding t:core Issues related to the akka-http-core module labels Aug 22, 2017
@jrudolph jrudolph added the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Aug 22, 2017
@jrudolph
Copy link
Member

jrudolph commented Aug 22, 2017 •
edited
Loading

👍

@jlprat
Copy link
Member Author

jlprat commented Aug 22, 2017

I will take this one, as we need it at work :)

@idzivinskyi
Copy link

👍 I'm looking forward to this. I spent few days to understand that akka-http does not support Forwarded headers, especially X-Forwarded-Proto header.

@jlprat jlprat removed the discuss Tickets that need some discussion before proceeding label Aug 28, 2017
jlprat added a commit to jlprat/akka-http that referenced this issue Aug 28, 2017
@jlprat
+htc Add X-Forwarded-Proto and X-Forwarded-Host akka#1377
b4086d3 
Refs: akka#1377

This PR adds support for the _de facto_ standard headers:
- `X-Forwarded-Host`
- `X-Forwarded-Proto`
@jlprat jlprat mentioned this issue Aug 28, 2017
Merged
@jlprat
Copy link
Member Author

jlprat commented Aug 28, 2017

PR to add support for X-Forwarded-Proto and X-Forwarded-Host is here: #1387

Adding support for Forwarded will come later.

jlprat added a commit to jlprat/akka-http that referenced this issue Sep 2, 2017
@jlprat
+htc Add X-Forwarded-Proto and X-Forwarded-Host akka#1377
04504f0 
Refs: akka#1377

This PR adds support for the _de facto_ standard headers:
- `X-Forwarded-Host`
- `X-Forwarded-Proto`
jlprat added a commit to jlprat/akka-http that referenced this issue Oct 3, 2017
@jlprat
+htc Add X-Forwarded-Proto and X-Forwarded-Host akka#1377
9209b58 
Refs: akka#1377

This PR adds support for the _de facto_ standard headers:
- `X-Forwarded-Host`
- `X-Forwarded-Proto`
jlprat added a commit that referenced this issue Oct 4, 2017
@jlprat
+htc Add X-Forwarded-Proto and X-Forwarded-Host #1377 (#1387)
f9e8783 
* +htc Add X-Forwarded-Proto and X-Forwarded-Host #1377

Refs: #1377

This PR adds support for the _de facto_ standard headers:
- `X-Forwarded-Host`
- `X-Forwarded-Proto`

* Fix typo and add more tests

* Add mima exclusions

* Apply feedback

* Reuse Host and remove not needed methods

* Rename getAddress to getHost
@jlprat jlprat added this to the 10.0.11 milestone Oct 4, 2017
@jrudolph jrudolph removed this from the 10.0.11 milestone Nov 30, 2017
@jrudolph jrudolph added this to the 10.0.11 milestone May 29, 2019
@jrudolph jrudolph reopened this May 29, 2019
@jrudolph jrudolph removed this from the 10.0.11 milestone May 29, 2019
@jrudolph jrudolph added the hackathon Issues that could be tackled during a hackathon label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted hackathon Issues that could be tackled during a hackathon help wanted Identifies issues that the core team will likely not have time to work on t:core Issues related to the akka-http-core module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrudolph @idzivinskyi @jlprat